FYS3150/Project-4
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Specified variable and added change to the last review point.

Browse Source
This commit is contained in:
Janita Willumsen
2023-12-05 15:32:39 +01:00
parent 5df0a2411b
commit 4b711a477e
5 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
review.md
View File

@@ -104,6 +104,7 @@ I agree!
- janitaws: So instead of "We ran a profiler" it should be "We used a profiler"? Could you suggest a way of formulating the sentence so that the info is correct?
- coryab: Yes to the first point. "To check if the parallelization was optimal, we used a profiler, which found that the program was efficient. The thing that scored slightly less was the MPI load balance, which is most likely because the master process gathered all data using blocking communication, which made the other processes wait, in addition to having one process work more."
- janitaws: If we simply state that the program was efficient we should include some sort of evidence supporting the statement, since the view of efficiency is subjective. Maybe we could include percentage here to support it, the profile gave a number right?
- janitaws: made a change to the entire paragraph, including reference to figure in appendix
[ ] 106: was => were
- janitaws: My previous comment might make this unnecessary?
- coryab: If you use my suggestion, then this can be checked off at the same time.